Switch tests away from using enzyme.mount (components/higher-order/with-state/test/index.js) #7829
Conversation
This switches all tests in `components/higher-order/with-state/test/index.js` from using enzyme.mount to `React.TestUtils`. This is because `enzyme` does not fully support React 16.3+ (and movement to do so is really slow). This will fix issues with breakage due to the enzyme incompatibility as components receive React 16.3+ features (such as `forwardRef` usage in #7557).
nerrad
added
[Type] Automated Testing
|
|
||
| // this is needed because TestUtils does not accept a stateless component. | ||
| // anything run through a HOC ends up as a stateless component. | ||
| const getTestComponent = ( WrappedComponent ) => { |
There was a problem hiding this comment.
We are using a similar HOC in other places should we implement it in a place where we can reuse it?
There was a problem hiding this comment.
:) Currently I've got pulls open for all the affected HOCs that implement this (or a variation of) when needed. I think there's definitely room for abstraction but I think that should be part of a larger discussion (via its own pull/issue) about creating our own abstraction for testing components. I'd like to focus on getting these pulls merged in first and then we can accumulate patterns that we notice across the various tests as a part of the discussion on the abstraction (I can contribute to that with patterns I noticed when doing these conversions).
There was a problem hiding this comment.
Also the current comment is currently against master branch incorrect. When/if #7557 gets implemented, then it will be completely correct because every HOC (created by createHigherOrderComponent will be wrapped by forwardRef).
There was a problem hiding this comment.
We are using a similar HOC in other places should we implement it in a place where we can reuse it?
We definitely should do it once we merge all PRs :) I'd prefer to do it in one go so we large enough codebase to sparkle proper discussion.
gziolo
deleted the
update/with-state.js-replace-usage-of-enzyme.mount-with-React.TestUtils
branch
ellatrix
added
[Type] Code Quality
Description
This switches all tests in
components/higher-order/with-state/test/index.jsfrom using enzyme.mount toReact.TestUtils. This is becauseenzymedoes not fully support React 16.3+ (and movement to do so is really slow). This will fix issues with breakage due to the enzyme incompatibility as components receive React 16.3+ features (such asforwardRefusage in #7557).Checklist: